Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable - expandableRows with some hidden columns #293

Closed
gatapia opened this issue May 2, 2016 · 2 comments
Closed

DataTable - expandableRows with some hidden columns #293

gatapia opened this issue May 2, 2016 · 2 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
1.0.0-beta.5

Comments

@gatapia
Copy link
Contributor

gatapia commented May 2, 2016

A data table with some hidden columns does not correctly show expanded content. i.e. expanded content sits in a cell with colspan ignoring hidden columns.

Example:

<p-datatable [value]="list" expandableRows="true">
  <p-column expander="true"></p-column>
  <p-column header="shown col"></p-column>
  <p-column [hidden]="true" header="hidden col"></p-column>
</p-datatable>

Expanding rows in this table will look strange, this is because the expaned row content has wrong colspan (3 instead of 2).
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 5, 2016
@cagataycivici
Copy link
Member

Will check for beta.6.

@gatapia gatapia mentioned this issue May 7, 2016
Merged
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 7, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.5 milestone May 7, 2016
@cagataycivici cagataycivici self-assigned this May 7, 2016
@gatapia
Copy link
Contributor Author

gatapia commented May 20, 2016

Still happening for scrollable tables, fix here:
#383

atretyak1985 pushed a commit to Nanitor/primeng that referenced this issue Jul 18, 2020
Merge pull request primefaces#293 from Nanitor/activity-log
160fb61 
Don't display a huge number of array values in the activity log list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
1.0.0-beta.5
Development

No branches or pull requests
2 participants
@gatapia @cagataycivici