Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar with showTime not updating model when only time has been changed #2941

Closed
bombadillo opened this issue May 31, 2017 · 3 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@bombadillo
Copy link

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Instead of a Plunkr Case, the issue can be viewed on the PrimeNG website: https://www.primefaces.org/primeng/#/calendar

Current behavior
Clicking the change time buttons in a calendar component with a showTime attribute does not change the models (bound ngModel) value until a date is selected. However, it does change the value within the calendar input.

Expected behavior
Clicking the change time buttons should update the model to the new value.

Minimal reproduction of the problem with instructions

@4kochi
Copy link

4kochi commented Jun 2, 2017

Same for us. We have a reactive form. For debugging there is an output in the form of form.getRawValue(). I can see that the model value is updated in the view, but the reactive form does value get's not update. Therefore the validation is not triggered.

bombadillo added a commit to bombadillo/primeng that referenced this issue Jun 5, 2017
gardinit added a commit to gardinit/primeng that referenced this issue Jun 19, 2017
gardinit added a commit to gardinit/primeng that referenced this issue Jun 19, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 23, 2017
@cagataycivici cagataycivici added this to the 4.1.1 milestone Jun 23, 2017
@cagataycivici cagataycivici modified the milestone: 4.1.1 Jul 19, 2017
@AyaSypron
Copy link

AyaSypron commented Oct 7, 2017

any updates here?

@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 19, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 19, 2017
@cagataycivici cagataycivici added confirmed and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Oct 25, 2017
@cagataycivici
Copy link
Member

Fixed now for 4.3.0

@cagataycivici cagataycivici self-assigned this Oct 25, 2017
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants