Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New grid system based on flex #3298

Closed
Tuizi opened this issue Jul 4, 2017 · 15 comments
Closed

New grid system based on flex #3298

Tuizi opened this issue Jul 4, 2017 · 15 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@Tuizi
Copy link

Tuizi commented Jul 4, 2017

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

The current grid system is based on the float layout.

Expected behavior

Add a new grid system based on the flex layout (because we are in 2017)

What is the motivation / use case for changing the behavior?

No need to present the popular display property: flex. PrimeNG is the only new framework that still use the old layout system: float. It could be great to have a grid system based on display: flex and even better in the future, based on display: grid

@ova2
Copy link

ova2 commented Jul 4, 2017

+1

I hate outdated float based layout too. For now, we can use Flexbox in Bootstrap 4. There is one section in the upcoming book which describes Flexbox intergration in PrimeNG. Project is here: https://github.com/ova2/angular-development-with-primeng/tree/master/chapter2/graphic-editor-bootstrap4

@Tuizi
Copy link
Author

Tuizi commented Jul 4, 2017

@ova2 On our side we will switch from PrimeNG grid system to Angular official Flex Layout system https://github.com/angular/flex-layout/wiki/Responsive-API

@ova2
Copy link

ova2 commented Jul 5, 2017 via email

@Mrtcndkn Mrtcndkn added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 5, 2017
@d668
Copy link

d668 commented Aug 7, 2017

@Tuizi angular/flex-layout is still in beta and full of bugs

@Tuizi
Copy link
Author

Tuizi commented Aug 7, 2017

@intergleam We use it here for 4 months and no blocking bugs. Angular will start to be more active with FlexLayout, I know its a beta but everything we were expecting work perfectly with this version right now

@d668
Copy link

d668 commented Aug 7, 2017

I have @angular/common 2.4.8, tried to install @angular/flex-layout 2.0.0-beta.8, and I have a bunch of errors...

WARNING in ./~/@angular/flex-layout/media-query/breakpoints/break-points-token.js 13:29 export 'InjectionToken' was not found in '@angular/core'

and much more

@Tuizi
Copy link
Author

Tuizi commented Aug 7, 2017

You should consider updating your Angular version, they don't support 2.4.x. It's in bold at the beginning of the README

@cagataycivici cagataycivici added Type: New Feature Issue contains a new feature or new component request and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Aug 23, 2017
@AlejandroFlorin
Copy link

+1 for this feature. It would be nice if we could use the other flexbox alignment options with the grid system (horizontal and vertical alignment, etc.)

@kolkov
Copy link

kolkov commented May 6, 2018

We need Native CSS Grid support too.

@cagataycivici cagataycivici added this to the 6.1.4 milestone Aug 31, 2018
@cagataycivici cagataycivici self-assigned this Aug 31, 2018
@cagataycivici
Copy link
Member

FlexGrid coming soon for 6.1.4.

@cagataycivici
Copy link
Member

Implemented for 6.1.4.

@cagataycivici
Copy link
Member

@SarvagyaS
Copy link

SarvagyaS commented Sep 20, 2018

I have bought Ultima theme. But, there are no styles for flexgrid classes in theme's CSS file. I am using flexgrid.css but that makes the page very unattractive.
Below I have posted the same form one with using ui-g classes and other with using flexgrid classes, one with flexgrid looks bad there is no padding in rows.
flexgrid
using flexgrid.
ui-g
using ui-g

@scblur869
Copy link

how long before the current Grid CSS is removed and FlexGrid is fully documented and all examples updated on the site with FlexGrid?

@cicciogeppo88
Copy link

Hello,
will it be possible to update the ultima primeng templates in order to use the flexgrid system? they are currently outdated and misleading,

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

10 participants