Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPicker: Selected Color value should start with a '#' in hex format #3376

Closed
kstruyven opened this issue Jul 12, 2017 · 0 comments
Closed
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@kstruyven
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
The ColorPicker input component returns a value for the Selected Color in hex format (default) without the '#' in front of the hex value. This sole value is not supported by other html style elements.

Expected behavior
Add a '#' in front of the returned color value.

What is the motivation / use case for changing the behavior?
It doesn't make sense to leave out the '#'. Every other html element's color style requires a '#' in front of color hex value. Now, we have to change the value of the model to specifically add a #, before it can be used somewhere else.

  • Angular version: 4.0.3

  • PrimeNG version: 4.1.0-rc.3

SefaMuratcanKatirci added a commit to SefaMuratcanKatirci/primeng that referenced this issue Jul 16, 2017
The '#' character added to colorpicker.ts when the format is default (hex). Then, in HTML, we do not need to add '#' for providing style.backgroundColor, because it already includes '#'
SefaMuratcanKatirci added a commit to SefaMuratcanKatirci/primeng that referenced this issue Jul 16, 2017
The '#' character added to colorpicker.ts when the format is default (hex). Then, in HTML, we do not need to add '#' for providing style.backgroundColor, because it already includes '#'
@cagataycivici cagataycivici self-assigned this Jul 18, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 18, 2017
@cagataycivici cagataycivici added this to the 4.1.1 milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants