Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Clears When Pressing Enter Editable Datatable #3547

Closed
jonatino opened this issue Aug 1, 2017 · 2 comments
Closed

Validation Clears When Pressing Enter Editable Datatable #3547

jonatino opened this issue Aug 1, 2017 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jonatino
Copy link

jonatino commented Aug 1, 2017

[X] bug report => Search github for a similar issue or PR before submitting

https://www.primefaces.org/primeng/#/datatable/editable

Current behavior
Upon pressing enter in a editable column which is required, the validation is cleared while clicking out of the field continues to show validation error.

Expected behavior
Validation error should still show up if user hits enter.

Minimal reproduction of the problem with instructions

alt text

Click editable field and clear it
Press enter

What is the motivation / use case for changing the behavior?
User's might not know that the field is invalid.

Please tell us about your environment:
Windows 10 x64 Chrome/FF/IE

  • Angular version: 2.0.X
    Angular 4.1.3

  • PrimeNG version: 2.0.X
    PrimeNG 4.1.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    ALL

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript 2.4.2, ES5

@cagataycivici cagataycivici self-assigned this Oct 2, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 2, 2017
@cagataycivici cagataycivici added this to the 4.2.2 milestone Oct 2, 2017
@Merve7 Merve7 closed this as completed in bf2e099 Oct 2, 2017
cagataycivici pushed a commit that referenced this issue Oct 4, 2017
@lhysrc
Copy link

lhysrc commented Nov 3, 2017

How to add validation for the editable DataTable? 😂

@thichnguyen
Copy link

How to validation for editTable DataTable?
If data is invalid (null,...), press enter key or tabspace. I wan't to focus this field and to show tooltip.
Please support for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

5 participants