Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar onClose event is fired even if overlay is not visible #3826

Closed
bossqone opened this issue Sep 4, 2017 · 0 comments
Closed

Calendar onClose event is fired even if overlay is not visible #3826

bossqone opened this issue Sep 4, 2017 · 0 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.2

Comments

@bossqone
Copy link
Contributor

bossqone commented Sep 4, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/opEfAscX5syzD1wY0KZo?p=preview

Current behavior
Calendar onClose event is fired even if overlay is not visible. Basically it's fired on every document click outside of calendar overlay.

Expected behavior
Event should be fired only when calendar/overlay is actually being closed.

  • PrimeNG version: 4.1.3

  • Browser: all
@bossqone bossqone mentioned this issue Sep 4, 2017
Closed
Sumragen pushed a commit to Sumragen/primeng that referenced this issue Sep 4, 2017
primefaces#3826 edited predicate to fired onClose event:added predica…
b7e153a 
…te those check is overlay visible
Sumragen pushed a commit to Sumragen/primeng that referenced this issue Sep 4, 2017
primefaces#3826 edited predicate to fired onClose event:added predica…
3c5ed4c 
…te those check is overlay visible
@Sumragen Sumragen mentioned this issue Sep 4, 2017
Merged
@cagataycivici cagataycivici self-assigned this Sep 12, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 12, 2017
@cagataycivici cagataycivici added this to the 4.2 milestone Sep 12, 2017
cagataycivici added a commit that referenced this issue Sep 12, 2017
@cagataycivici
Merge pull request #3832 from Sumragen/3826-unexpected-onclose-event
d64bdb7 
#3826 edited predicate to fired onClose event:added predicate those c…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@bossqone @cagataycivici