Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown list shows "empty" text for null/empty values #4112

Closed
Ketec opened this issue Oct 6, 2017 · 0 comments
Closed

Dropdown list shows "empty" text for null/empty values #4112

Ketec opened this issue Oct 6, 2017 · 0 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0

Comments

@Ketec
Copy link

Ketec commented Oct 6, 2017

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
As of 4.2.2 update "empty" still shows up in the list of items if label is null or empty string.
This does not allow adding a empty selection to the dropdown.
Using ' ' string with a space causes dropdown to also display that "space" not default placeholder.

Expected behavior
Do not add any default text if null/length 0. If set to maintain selection height, how about
content: "\200b"; in before selector (0 width space) or set min height in style.
@Ketec Ketec changed the title dropdown list shows "empty" with hull/empty string dropdown list shows "empty" with null/empty string Oct 6, 2017
@cagataycivici cagataycivici changed the title dropdown list shows "empty" with null/empty string Dropdown list shows "empty" text for null/empty values Oct 18, 2017
@cagataycivici cagataycivici self-assigned this Oct 18, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 18, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 18, 2017
televic-education-ruben added a commit to televic-education-ruben/primeng that referenced this issue Jun 28, 2018
@televic-education-ruben
Merge pull request primefaces#6 in TEDU_COMMON/primeng from feature/v…
45a31a9 
…ersion4 to develop

* commit 'd7fdfc9ff5707543c0dd0d1e55a0dad5aaddc1f9': (1032 commits)
  FIX: correct path in d.ts. and js file
  Duplicate onSelect event removed(docs)
  Fixed primefaces#4112
  Docs for progress spinner
  strokeWidth and fill properties for ProgressSpinner
  Initial drop-in of new p-progressSpinner component
  Add text
  Fixed primefaces#3460
  Fixed primefaces#4168
  Fixed primefaces#4152
  Add serenity
  Add null check
  Fixed primefaces#4148
  Fixed primefaces#4141
  Validation class in calendar component
  Fixed primefaces#4131
  New dev version
  Set version
  Better fix for primefaces#4103
  Fixed AOT error
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@cagataycivici @Ketec