Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datatable radio/checkbox selections not updated at events #4119

Closed
Ketec opened this issue Oct 6, 2017 · 2 comments
Closed

datatable radio/checkbox selections not updated at events #4119

Ketec opened this issue Oct 6, 2017 · 2 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0

Comments

@Ketec
Copy link

Ketec commented Oct 6, 2017 •
edited
Loading

There is no guarantee in receiving a response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
selectRowWithRadio
toggleRowWithCheckbox
toggleRowsWithCheckbox

Are missing this.selectionChange.emit(this.selection); therefor the selection is not up to date when listening to the onRowSelect event.
wooleverj added a commit to wooleverj/primeng that referenced this issue Oct 6, 2017
@wooleverj
Update datatable to emit selection before rowselect
54617ad 
I believe this will address the issue primefaces#4119.  The problem is that the datatable was emitting the selection after it fired the onRowSelect event.  This makes it seem like the selection array never got updated.
@wooleverj wooleverj mentioned this issue Oct 6, 2017
Merged
@wooleverj
Copy link
Contributor

I ran into this same thing and changed the selection emitter to be before the onRowSelect event where it currently is after the event gets fired. I believe this pull request will help this issue.

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 20, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 20, 2017
@cagataycivici cagataycivici added confirmed and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 24, 2017
@cagataycivici
Copy link
Member

PR merged.

@cagataycivici cagataycivici self-assigned this Oct 24, 2017
@cagataycivici cagataycivici changed the title datatable radio/checkbox selections not updating selection array datatable radio/checkbox selections not updated at events Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
3 participants
@cagataycivici @wooleverj @Ketec