Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider onSlideEnd does not fire on touch end #4173

Closed
scurk1415 opened this issue Oct 13, 2017 · 0 comments
Closed

Slider onSlideEnd does not fire on touch end #4173

scurk1415 opened this issue Oct 13, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@scurk1415
Copy link

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/HzzAg3ZmOsFbkS2JtGWw?p=preview

Current behavior
Slider onSlideEnd does not work with touch events.

Expected behavior
It should work with touch and mouse events

Minimal reproduction of the problem with instructions
Go to developer tools and turn on device mode or open the plunker site on a mobile device. The slider onSlideEnd is not fired (onChange event works).

  • Angular version:
    4.4.4

  • PrimeNG version:
    4.2.2

@scurk1415 scurk1415 changed the title Slider onSlideEnd Slider onSlideEnd does not fire on touch end Oct 13, 2017
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 19, 2017
@cagataycivici cagataycivici removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 13, 2018
@cagataycivici cagataycivici self-assigned this Dec 13, 2018
@cagataycivici cagataycivici added this to the 7.0.1 milestone Dec 13, 2018
cagataycivici added a commit that referenced this issue Dec 13, 2018
fixed #4173 - Slider onSlideEnd does not fire on touch end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants