Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled button should force removal of ui-state-hover class #419

Closed
brian428 opened this issue May 26, 2016 · 1 comment
Closed

Disabled button should force removal of ui-state-hover class #419

brian428 opened this issue May 26, 2016 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@brian428
Copy link
Contributor

brian428 commented May 26, 2016

Just a small bug, but if you have a button with its disabled property bound:

<button pButton type="button" label="Deselect" icon="fa fa-minus-circle" title="Deselect"
        [disabled]="selectedItems.length === 0" (click)="onDeselectClick()"></button>

If the click handler clears the selectedItems array, the disabled binding is updated and the button becomes disabled. But the ui-state-hover class is still applied to the button, meaning it is now disabled and still lit up with the hover class.

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 27, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.7 milestone May 27, 2016
@cagataycivici cagataycivici self-assigned this May 27, 2016
@cagataycivici
Copy link
Member

Fix checked in, thank you.

atretyak1985 pushed a commit to Nanitor/primeng that referenced this issue Jul 18, 2020
[NNTR-384]Untitled software - make clickable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants