Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataTable when scrollable and scrollheight is set - style issue #465

Closed
Floppynator opened this issue Jun 8, 2016 · 10 comments
Closed

dataTable when scrollable and scrollheight is set - style issue #465

Floppynator opened this issue Jun 8, 2016 · 10 comments

Comments

@Floppynator
Copy link

Floppynator commented Jun 8, 2016 •
edited
Loading

a dataTable style is broken when scrollable and scrollHeight attribute is set.
@Floppynator Floppynator changed the title dataTable nested in dataTable style issue dataTable nested in a p-dialog - style issue Jun 14, 2016
@Floppynator Floppynator changed the title dataTable nested in a p-dialog - style issue dataTable when scrollable and scrollheight is set - style issue Jun 14, 2016
@rahuja910
Copy link

any update on this?

lbamburski added a commit to lbamburski/primeng that referenced this issue Sep 20, 2016
@lbamburski
Scrollable works with resizableColumns, reorderableColumns,
b3946db 
 sortable, columnResizeMode, scrollHeight, scrollWidth and column toggler.

Fixes issues with scrollable:
-DataTable with scroll and few data causes headers and table cells to misalign primefaces#917
-dataTable when scrollable and scrollheight is set - style issue primefaces#465
-Column Reorder and Resize support for Scrollable DataTable primefaces#238
-Maybe: DataTable with explicit widths causes headers and table cells to misalign primefaces#487
-Maybe: Datatable scrollable="true" breaks column template header primefaces#859
@lbamburski lbamburski mentioned this issue Sep 20, 2016
Closed
lbamburski added a commit to lbamburski/primeng that referenced this issue Sep 21, 2016
@lbamburski
Scrollable works with resizableColumns, reorderableColumns,
a36e55b 
   sortable, columnResizeMode, scrollHeight, scrollWidth, header,footer, filter, paginator, selectionMode,
  expandableRows with inner table and column toggler.

  Fixed footer width and partially pagination width when scrollWidth is used

Fixes issues with scrollable:
-DataTable with scroll and few data causes headers and table cells to misalign primefaces#917
-dataTable when scrollable and scrollheight is set - style issue primefaces#465
-Column Reorder and Resize support for Scrollable DataTable primefaces#238
-Maybe: DataTable with explicit widths causes headers and table cells to misalign primefaces#487
-Maybe: Datatable scrollable="true" breaks column template header primefaces#859
@lbamburski lbamburski mentioned this issue Sep 21, 2016
Closed
lbamburski added a commit to lbamburski/primeng that referenced this issue Sep 21, 2016
@lbamburski
Scrollable works with resizableColumns, reorderableColumns,
f70b8f6 
   sortable, columnResizeMode, scrollHeight, scrollWidth, header,footer, filter, paginator, selectionMode,
  expandableRows with inner table and column toggler.

  Fixed footer width and partially pagination width when scrollWidth is used

Fixes issues with scrollable:
-DataTable with scroll and few data causes headers and table cells to misalign primefaces#917
-dataTable when scrollable and scrollheight is set - style issue primefaces#465
-Column Reorder and Resize support for Scrollable DataTable primefaces#238
-Maybe: DataTable with explicit widths causes headers and table cells to misalign primefaces#487
-Maybe: Datatable scrollable="true" breaks column template header primefaces#859
@lbamburski lbamburski mentioned this issue Sep 21, 2016
Closed
lbamburski added a commit to lbamburski/primeng that referenced this issue Sep 21, 2016
@lbamburski
Scrollable works with resizableColumns, reorderableColumns,
95532d9 
   sortable, columnResizeMode, scrollHeight, scrollWidth, header,footer, filter, paginator, selectionMode,
  expandableRows with inner table and column toggler.

  Fixed footer width and partially pagination width when scrollWidth is used

Fixes issues with scrollable:
-DataTable with scroll and few data causes headers and table cells to misalign primefaces#917
-dataTable when scrollable and scrollheight is set - style issue primefaces#465
-Column Reorder and Resize support for Scrollable DataTable primefaces#238
-Maybe: DataTable with explicit widths causes headers and table cells to misalign primefaces#487
-Maybe: Datatable scrollable="true" breaks column template header primefaces#859
@sittingbool
Copy link
Contributor

sittingbool commented Dec 9, 2016 •
edited
Loading

Same here. If I set a percentage value into the scrollHeight it sets the max-height of the body to 0px

@sittingbool
Copy link
Contributor

The error happens Here: https://github.com/primefaces/primeng/blob/master/components/datatable/datatable.ts#L1620.

My Setup: I have the table inside a tab-panel. The first tab has a selection which changes the list shown in the table, the second has the table. After I change tabs, select and come back to the table this line will set 0px and never be called again.

@cagataycivici
Copy link
Member

Unable to replicate with newer versions, please try with 2.0.2.

@bbonczek
Copy link

This issue still affects me - both on 2.0.2 and 2.0.3

@cagataycivici
Copy link
Member

Can you provide a plunkr please?

@bbonczek
Copy link

Yup, I'm working on it right now.

@cagataycivici
Copy link
Member

Thanks, we'll do 4.0.RC1 on wednesday, I can ask my colleague to check this until then.

@bbonczek
Copy link

There is everything fine with with scrollWidth. The scrollHeight is the one, that seems to have problems:

http://plnkr.co/edit/lwsjtNJCWW5qEBtOOXiY?p=preview

@ericrovtar
Copy link

Was there ever a fix for this? I'm still finding the issue in the latest npm package.

atretyak1985 pushed a commit to Nanitor/primeng that referenced this issue Jul 18, 2020
Merge pull request primefaces#465 from atretyak1985/issue_#NNTR-449
3ec4ba1 
[NNTR-449]Create software issue detail page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cagataycivici @Floppynator @ericrovtar @bbonczek @sittingbool @rahuja910