Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for MenuItem icons in breadcrumb #4891

Closed
KeithGillette opened this issue Jan 19, 2018 · 0 comments
Closed

Support for MenuItem icons in breadcrumb #4891

KeithGillette opened this issue Jan 19, 2018 · 0 comments
Assignees
@cagataycivici
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
6.0.1

Comments

@KeithGillette
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[X] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
The icon property of MenuItem is ignored by BreadcrumbComponent.

Expected behavior
BreadcrumbComponent displays specified icon to left of label like most other PrimeNG menu components.

What is the motivation / use case for changing the behavior?

  • Provide additional information to user about the items displayed in the breadcrumb navigation.
  • Create more consistent API/developer experience across PrimeNG menu components.
  • Make BreadcrumbComponent even more awesome.
@cagataycivici cagataycivici changed the title Enhancement: Support MenuItem.icon in Breadcrumb Support for MenuItem icons in breadcrumb Mar 26, 2018
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Mar 26, 2018
FirstVertex added a commit to FirstVertex/primeng that referenced this issue Jun 29, 2018
@FirstVertex
Support icon field of MenuItem
fcec919 
If `MenuItem` structure specifies an icon, let's draw that on the Breadcrumbs.
Additional fix is provided for customizing `home.icon` in the case where `home.routerLink` is defined.
It can solve primefaces#4891
FirstVertex added a commit to FirstVertex/primeng that referenced this issue Jun 29, 2018
@FirstVertex
Support icon field of MenuItem
a84da3f 
If `MenuItem` structure specifies an icon, let's draw that on the Breadcrumbs.  Applying a class of `ui-menuitem-icon` would allow user to customize display, if desired.
Additional fix is provided for customizing `home.icon` in the case where `home.routerLink` is defined.
It can solve primefaces#4891
@FirstVertex FirstVertex mentioned this issue Jun 29, 2018
Closed
FirstVertex added a commit to FirstVertex/primeng that referenced this issue Jun 29, 2018
@FirstVertex
Support icon field of MenuItem
3f5f145 
If `MenuItem` structure specifies an icon, let's draw that on the Breadcrumbs.  Applying a class of `ui-menuitem-icon` would allow user to customize display, if desired.
Additional fix is provided for customizing `home.icon` in the case where `home.routerLink` is defined.
It can solve primefaces#4891
@FirstVertex FirstVertex mentioned this issue Jun 29, 2018
Merged
@cagataycivici cagataycivici added this to the 6.0.1 milestone Jul 11, 2018
@cagataycivici cagataycivici self-assigned this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
2 participants
@cagataycivici @KeithGillette