Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Mask sets DIRTY state incorrectly #5045

Closed
ghost opened this issue Feb 1, 2018 · 0 comments
Closed

Input Mask sets DIRTY state incorrectly #5045

ghost opened this issue Feb 1, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ghost
Copy link

ghost commented Feb 1, 2018

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Clicking (focus) in the input mask and directly leaving it (blur) without typing any character sets the input state to DIRTY. That is incorrect and it not aligned with the Angular standard behavior. It also leads to a confusing visual user feedback.

Expected behavior
Only set DIRTY state if the user types anything (no matter if valid or invalid character).

  • Angular version: 5.2.2
  • PrimeNG version: 4.0.3
@cagataycivici cagataycivici self-assigned this Mar 9, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 9, 2018
@cagataycivici cagataycivici added this to the 5.2.2 milestone Mar 9, 2018
cagataycivici added a commit that referenced this issue Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

1 participant