Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataGrid p-footer display glitch #5156

Closed
TheRealFenrir opened this issue Feb 15, 2018 · 1 comment
Closed

DataGrid p-footer display glitch #5156

TheRealFenrir opened this issue Feb 15, 2018 · 1 comment
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
5.2.1

Comments

@TheRealFenrir
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/wYNc6cJclbRoON8lHqHX?p=preview

Current behavior
The footer is displayed with rounded corners on top, like a header.

Expected behavior
The footer should have rounded corners on the bottom.

Minimal reproduction of the problem with instructions
Make a DataGrid with a p-footer.

What is the motivation / use case for changing the behavior?
Correct the display of the footer.
@TheRealFenrir TheRealFenrir mentioned this issue Feb 15, 2018
Merged
cagataycivici added a commit that referenced this issue Mar 5, 2018
@cagataycivici
Merge pull request #5157 from TheRealFenrir/patch-1
2e77b3a 
Fix for #5156
@cagataycivici cagataycivici self-assigned this Mar 5, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 5, 2018
@cagataycivici cagataycivici added this to the 5.2.1 milestone Mar 5, 2018
@cagataycivici cagataycivici changed the title DataGrid p-footer displays incorrectly DataGrid p-footer display glitch Mar 5, 2018
@cagataycivici
Copy link
Member

Merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
5.2.1
Development

No branches or pull requests
2 participants
@cagataycivici @TheRealFenrir