Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ui-multiselect-open class to multiselect component #5680

Closed
rsikdar opened this issue May 3, 2018 · 1 comment
Closed

Add ui-multiselect-open class to multiselect component #5680

rsikdar opened this issue May 3, 2018 · 1 comment
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@rsikdar
Copy link
Contributor

rsikdar commented May 3, 2018

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[ x ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Hello, I would like to propose adding a ui-multiselect-open class to the multiselect component when the overlay is visible.

Expected behavior
The container div has a class "ui-multiselect-open" when the overlay is visible

What is the motivation / use case for changing the behavior?

The dropdown component already has a ui-dropdown-open class that I was using to style the dropdown differently when the overlay is visible, but I am unable to use similar styling with the multiselect component. Once the user clicks inside the overlay, the label container loses the ui-state-focus class, and there is no way through css to know the overlay is visible.

Thanks!

@rsikdar
Copy link
Contributor Author

rsikdar commented May 3, 2018

Created pull request for the feature - #5681

cagataycivici added a commit that referenced this issue May 31, 2018
Add ui-multiselect-open class - Fix for #5680
@cagataycivici cagataycivici self-assigned this May 31, 2018
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label May 31, 2018
@cagataycivici cagataycivici added this to the 6.0.0-alpha.2 milestone May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants