Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-message severity "warn" shows no icon (primeicons) #5894

Closed
Laurensvdw opened this issue Jun 12, 2018 · 1 comment · Fixed by #6082
Closed

p-message severity "warn" shows no icon (primeicons) #5894

Laurensvdw opened this issue Jun 12, 2018 · 1 comment · Fixed by #6082
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
6.0.2

Comments

@Laurensvdw
Copy link

Laurensvdw commented Jun 12, 2018 •
edited
Loading

I'm submitting a ...

[ x] bug report 
[ ] feature request
[ ] support request

Current behavior
Message with sevirity "warn" does not show an icon. A wrong icon class is being added to the component being "pi-ex", this should be "pi-exclamation-triangle" as noted in the documentation of the icons

Expected behavior
Message with serverity "warn" should show an icon

Minimal reproduction of the problem with instructions
It is visible on the documentation page's messages section

  • Angular version:
    6.0.0

  • PrimeNG version:
    primeng 6.0.0-beta.1
    primeicons 1.0.0-beta.7
@ctrl-brk
Copy link

Works for me in Omega theme

@pratheeshp007 pratheeshp007 mentioned this issue Jul 17, 2018
Merged
@cagataycivici cagataycivici self-assigned this Jul 26, 2018
cagataycivici added a commit that referenced this issue Jul 26, 2018
@cagataycivici
Merge pull request #6082 from pratheeshp007/fix-p-message-icon
d825717 
#5894 - corrected the icon class name for warning message
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jul 26, 2018
@cagataycivici cagataycivici added this to the 6.0.2 milestone Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
6.0.2
Development

Successfully merging a pull request may close this issue.

#5894 - corrected the icon class name for warning message pratheeshp007/primeng
3 participants
@cagataycivici @ctrl-brk @Laurensvdw