Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-dialog with height has invalid behavior while resizing #5974

Closed
dicbrus opened this issue Jun 27, 2018 · 2 comments · Fixed by #6240
Closed

p-dialog with height has invalid behavior while resizing #5974

dicbrus opened this issue Jun 27, 2018 · 2 comments · Fixed by #6240
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dicbrus
Copy link
Contributor

dicbrus commented Jun 27, 2018

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/angular-uamnc8?embed=1&file=src/app/app.component.html

Current behavior
Pre-settings: p-dialog has [heigh] value

In case of viewport (browser window height) has not enough height to show the whole dialog, content height is set to 75% of viewport. But window height is not changed and keeps initial value.
That cause to bug, that scrollable content area has height not agreed with dialog height and empty spaces.

Expected behavior

If viewport has not enough height, not only content area should change its height, but also p-dialog height should be changed.

What is the motivation / use case for changing the behavior?

Fixed p-dialog with height is useless on resize.

  • **Angular version: 6

  • PrimeNG version: 6

  • Browser: Chrome | Firefox | Opera

  • Language: TypeScript

@dicbrus
Copy link
Contributor Author

dicbrus commented Aug 5, 2018

verified at @6.0.2 - bug still presents,
updated stackblitz

dicbrus added a commit to dicbrus/primeng that referenced this issue Aug 6, 2018
@cagataycivici cagataycivici self-assigned this Aug 29, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 29, 2018
@cagataycivici cagataycivici added this to the 6.1.3 milestone Aug 29, 2018
@apolon23
Copy link

try [contentStyle]="{'min-height':'your value'}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants