Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: checkbox selection, items where 'selectable:false' don't have a check box #6144

Closed
nanafocus opened this issue Jul 23, 2018 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@nanafocus
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
Tree: checkbox selection, items where 'selectable:false' still have a check box #5359


**Current behavior**
Items that have 'selectable' as false in the tree don't have checkbox.

**Expected behavior**
Checkboxes should be displayed on items where 'selectable' is false.

**Minimal reproduction of the problem with instructions**
Create a tree with a selection mode as checkbox. Set the items to 'selectable' false, note you will not see the checkbox.

**What is the motivation / use case for changing the behavior?**
I want to see the checkbox when selectable is false because I use this property to disable the tree. I want to see the complete tree with the checkbox also when it is disable.

* **Angular version:** 6.0.8

* **PrimeNG version:** 6.0.0

@estenp
Copy link

estenp commented Jan 17, 2019

This doesn't actually appear to be a bug, but rather an intentional change made by the team in the 6.0 release (selectable option added to *ngIf on the .ui-chkbox : 1e66a7c...master).

I guess the question is why was this change made and would the team be willing to accept a pull request adding the old disabled checkbox display back in, or at least possible adding an option to tree node for turning it's display on or off.

@cagataycivici cagataycivici self-assigned this Feb 19, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 19, 2019
@cagataycivici cagataycivici added this to the 7.1.0 milestone Feb 19, 2019
darkhelmet pushed a commit to weknowtraining/primeng that referenced this issue Mar 25, 2019
@KhaledGabr
Copy link

This doesn't really fix the issue.
Seletable Property should be used to show or hide the selection checkbox.

Please, add a new property called, disabled that would disable a checkbox. However, the selectable button needs to be reverted back like it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants