Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calendar][PrimeIcons] - Chevrons lack tabindex which interrupts tabbing, empty href #6270

Closed
Mysame opened this issue Aug 8, 2018 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Mysame
Copy link
Contributor

Mysame commented Aug 8, 2018

<a class="ui-datepicker-prev ui-corner-all" href="#" (click)="navBackward($event)" *ngIf="i === 0">
<span class="pi pi-chevron-left"></span>
</a>
<a class="ui-datepicker-next ui-corner-all" href="#" (click)="navForward($event)" *ngIf="numberOfMonths === 1 ? true : (i === numberOfMonths -1)">
<span class="pi pi-chevron-right"></span>
</a>

Chevrons get "tabbed" to, which makes tabbing out of a Calendar a 2-tab process.
Replicatable on https://www.primefaces.org/primeng/#/calendar , enter a Calendar, press "tab", you can breakpoint and/or notice the left chevron colouring blue.

Fix: Give the <a> a tabindex of -1

Additionally, empty href's should be replaced by appropriate cursor styling

@Mysame Mysame changed the title Calendar - Chevrons lack tabindex which interrupts tabbing, empty href [Calendar][PrimeIcons] - Chevrons lack tabindex which interrupts tabbing, empty href Aug 8, 2018
@anfeloaiza
Copy link

+1

@Mysame
Copy link
Contributor Author

Mysame commented Nov 12, 2018

@cagataycivici I regret to inform that this is not fixed by #6760 .

A distinction should be made between what requires tabindex="0" and tabindex="-1".
-1 will be ignored by browser.

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Apr 22, 2019
@cagataycivici cagataycivici added this to the 7.1.2 milestone Apr 22, 2019
@cagataycivici cagataycivici modified the milestones: 7.1.3, 7.1.2 Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants