Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace href="#" with tabindex="0" #6760

Closed
cagataycivici opened this issue Oct 25, 2018 · 1 comment
Closed

Replace href="#" with tabindex="0" #6760

cagataycivici opened this issue Oct 25, 2018 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

Links used in components such as close icon of a dialog renders an anchor with href="#" to make it focusable, however event should be prevented with this approach and browsers displays it as a link to navigate. Instead use tabindex so browser does not display anything and element is still focusable.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 25, 2018
@cagataycivici cagataycivici added this to the 7.0.0-beta.1 milestone Oct 25, 2018
@cagataycivici cagataycivici self-assigned this Oct 25, 2018
@rauljuarezdf
Copy link

rauljuarezdf commented Nov 15, 2018

I'm having this issue with menu items as well, the event is not prevented (thus, the browser scrolls to the top), can this also be fixed there

Ignore that, this happens when I show a confirmation dialog appended to "body"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants