Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcut to lightbox so a user can escape out of the lightbox without use of the mouse #6456

Closed
markleppke opened this issue Sep 5, 2018 · 0 comments
Closed

Add keyboard shortcut to lightbox so a user can escape out of the lightbox without use of the mouse #6456

markleppke opened this issue Sep 5, 2018 · 0 comments
Assignees
@yigitfindikli
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.0.1

Comments

@markleppke
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[ x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

What is the motivation/use case for changing the behavior?
Provide better accessibility for the lightbox UI, a fallback in case the close icon fails to show up, or in case the image that gets displayed is larger than the screen that it's displayed on.

Using the Esc key seems like a likely candidate to allow a user to escape out of the lightbox modal with a keyboard shortcut.
@yigitfindikli yigitfindikli self-assigned this Jul 5, 2019
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 5, 2019
@yigitfindikli yigitfindikli added this to the 8.0.1 milestone Jul 5, 2019
yigitfindikli added a commit that referenced this issue Jul 5, 2019
@yigitfindikli
fixed #6456 Add keyboard shortcut to lightbox so a user can escape ou…
56ddbc0 
…t of the lightbox without use of the mouse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.0.1
Development

No branches or pull requests
2 participants
@markleppke @yigitfindikli