Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown and MultiSelect converts filter value to lowercase #6779

Closed
donriver opened this issue Oct 29, 2018 · 0 comments
Closed

Dropdown and MultiSelect converts filter value to lowercase #6779

donriver opened this issue Oct 29, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@donriver
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting

https://www.primefaces.org/primeng/#/dropdown

Current behavior

Currently, all entered text in filter for drop down is converted to Lower Case.

Dropdown.prototype.onFilter = function (event) {
var inputValue = event.target.value.toLowerCase();
if (inputValue && inputValue.length) {
this.filterValue = inputValue;
this.activateFilter();
}
else {
this.filterValue = null;
this.optionsToDisplay = this.options;
}
this.optionsChanged = true;
};

Expected behavior
Leave text as it is.

Minimal reproduction of the problem with instructions

  1. open showcase and select dropdown page (https://www.primefaces.org/primeng/#/dropdown)
  2. go to "Content with Filters" case
  3. open and type "B" in the filter

What is the motivation / use case for changing the behavior?
The customers want to see the entered text without any changes.

Please tell us about your environment:
Windows 10, VS Code

  • Angular version: 5.X
    Angular 6.1.4

  • PrimeNG version: 5.X
    PrimeNG 6.1.2
    Ultima themes engine 5.2.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    All browsers where this could be reproduced - not browser specific

dinesh-here pushed a commit to dinesh-here/primeng that referenced this issue Nov 29, 2018
… is converting to lowercase in filter method
@cagataycivici cagataycivici changed the title all entered text in filter for p-dropdown is converted to Lower Case Dropdown and MultiSelect converts filter value to lowercase Dec 11, 2018
@cagataycivici cagataycivici self-assigned this Dec 11, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 11, 2018
@cagataycivici cagataycivici added this to the 7.0.1 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants