Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert maximize should not remove modal blockScroll #6905

Closed
viceice opened this issue Nov 22, 2018 · 0 comments
Closed

Revert maximize should not remove modal blockScroll #6905

viceice opened this issue Nov 22, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@viceice
Copy link

viceice commented Nov 22, 2018

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Waiting Time: ~8 weeks.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/github-f9d8dx

Current behavior

If i set modal, blockScroll and maximizable and open the dialog, the body scroll ist disabled.
If i then maximize and revert the dialog, the body is scrollable.

Expected behavior

The body is not scrollable after revert maximize.

Minimal reproduction of the problem with instructions

https://stackblitz.com/edit/github-f9d8dx

Here this.blockScroll should be checked.

this.domHandler.addClass(document.body, 'ui-overflow-hidden');

I can send a PR. The fix will be very easy.

What is the motivation / use case for changing the behavior?

Simply because this is a bug. 😁

Please tell us about your environment:

Windows Server 2012R2, Windows 10 18.03

  • Angular version: 6.X, 7.X
  • PrimeNG version: 6.1.6
  • Browser: all
  • Language: all

  • Node (for AoT issues): node --version = v10.13.0

@viceice viceice changed the title [Dialog] Revert maximize should not remove blockScroll [Dialog] Revert maximize should not remove modal blockScroll Nov 22, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 1, 2019
@cagataycivici cagataycivici added this to the 8.1.0 milestone Oct 1, 2019
@yigitfindikli yigitfindikli changed the title [Dialog] Revert maximize should not remove modal blockScroll Revert maximize should not remove modal blockScroll Oct 1, 2019
JacobSiegle pushed a commit to JacobSiegle/primeng that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants