Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-fileUpload component has bug on select file #7149

Closed
wszgrcy opened this issue Jan 19, 2019 · 1 comment
Closed

p-fileUpload component has bug on select file #7149

wszgrcy opened this issue Jan 19, 2019 · 1 comment
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
7.1.3

Comments

@wszgrcy
Copy link

wszgrcy commented Jan 19, 2019 •
edited
Loading

Current Waiting Time: ~1weeks.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

When I click choose btn(like button but a span ),I click on icon but can't open select file.
so I saw the source ,I find the icon has keep out the input Tag,so I add css z-index:1,and click ,
success open dialog
Expected behavior

input file add css z-index:1
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version:

official website

  • PrimeNG version:

4.x 7.x (I think all version has this because the latest version has this bug)

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome latest

  • Language:
    official website

  • Node (for AoT issues): node --version =
@rafa-suagu
Copy link

@cagataycivici some news here?

matthiasblaesing added a commit to matthiasblaesing/primeng that referenced this issue May 9, 2019
@matthiasblaesing
primefaces#7149 Clicking icon in advanced fileupload button does not …
a2d97df 
…open filechooser

The icon in the "Choose" button of the advanced fileupload button is
positioned absolute and is defined after the <input type="file">
element, which is also position=absolute.

So when a click is done in the region of the icon, the event is not
recorded on the file upload element, but on the icon and thus swallowed.

The solution is to raise the file element over the other elements via
a z-index style. This is considered to be save, as the button creates
a new stacking context.
cagataycivici added a commit that referenced this issue May 10, 2019
@cagataycivici
Merge pull request #7660 from matthiasblaesing/fileupload-icon-not-cl…
ccdb367 
…ickable

#7149 Clicking icon in advanced fileupload button does not open filechooser
@cagataycivici cagataycivici self-assigned this May 10, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 10, 2019
@cagataycivici cagataycivici added this to the 7.1.3 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
7.1.3
Development

No branches or pull requests
3 participants
@rafa-suagu @cagataycivici @wszgrcy