Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar doesn't clean up modality #7170

Closed
jensengar opened this issue Jan 25, 2019 · 1 comment
Closed

Calendar doesn't clean up modality #7170

jensengar opened this issue Jan 25, 2019 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jensengar
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Calendar with ui-touch enabled doesn't always disableModality. I noticed this when putting the calendar component in a ngbModal. With the calendar displayed, click outside the modal. You are left with just a dark overlay and can't interact with anything on the page. My suspicion is the ngbModal is destroying the components outright but the calendar doesn't fully clean up after itself.

Expected behavior
Calendar should clean up after itself (modality included) when it's destroyed. I suspect all you need to do is call disableModality in ngOnDestroy.

I have a workaround in my own code and don't have time to pr a fix right now. Workaround is to simply call the Calendar's disableModality fn when cleaning up the ngbModal.

@jonasvoelcker
Copy link

I've got the same issue and fixed it in my calendar.js according to the behaviour of "onInputKeydown".

I would really much appreciate it to merge in my pull request:

#7175

@cagataycivici cagataycivici self-assigned this Feb 28, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 28, 2019
@cagataycivici cagataycivici added this to the 7.1.0 milestone Feb 28, 2019
darkhelmet pushed a commit to weknowtraining/primeng that referenced this issue Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants