Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoWidth from Dropdown #7337

Closed
cagataycivici opened this issue Mar 5, 2019 · 3 comments
Closed

Remove autoWidth from Dropdown #7337

cagataycivici opened this issue Mar 5, 2019 · 3 comments
Assignees
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

autoWidth causes significant performance problems so remove the property and let the page author define the width of the dropdown.

@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Breaking Change Issue contains a breaking change related to a specific component labels Mar 5, 2019
@cagataycivici cagataycivici added this to the 7.1.0-rc.1 milestone Mar 5, 2019
@cagataycivici cagataycivici self-assigned this Mar 5, 2019
@dmytro-gokun
Copy link

@cagataycivici I think CHANGELOG has to be updated, so this is listed as a breaking change

@mertsincan
Copy link
Member

mertsincan commented Mar 18, 2019

@dmytro-gokun, Thanks a lot for your suggestion. Fixed now. Please check it ;)

https://github.com/primefaces/primeng/blob/master/CHANGELOG.md

@dmytro-gokun
Copy link

@mertsincan I hate too be that pedantic, but i'd expect to see that under 7.1.0, not 7.1.0-rc.1
You see, we use your great library in a stable product and we do not update to release candidates. So, the only time we update is when there is a new stable version out. And a changelog for that version is what we check to see if there any breaking changes that require our attention. And I think this is how the most of enterprise customers do it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants