Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome doesn't respect the autocomplete property of the p-autocomplete component #8096

Closed
francovegini opened this issue Aug 27, 2019 · 10 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@francovegini
Copy link

francovegini commented Aug 27, 2019

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
The p-autocomplete component has the autocomplete attribute set to off by default. However, even with this value, Google Chrome's autocompletion is still displayed, causing the problem shown in the third image (Chrome's autocompletion appears over the component list).

inspect_element

chrome_autofill

image

Expected behavior
The expected behavior is Google Chrome's autocompletion not being displayed, but after some research, I found out that Chrome ignores the autocomplete property when it is set to "off".

To fix this, I created a new @input in the p-autocomplete component and associated the autocomplete HTML property with it, in a way that the developer is able to send a value that actually disables Chrome's autocompletion.

Please take a look at PR #8097

References:
https://stackoverflow.com/questions/15738259/disabling-chrome-autofill
https://bugs.chromium.org/p/chromium/issues/detail?id=370363#c7

  • Angular version: 7.X

  • PrimeNG version: 7.X

  • Browser: [Chrome]

  • Language: [all]

@csvinhal
Copy link
Contributor

csvinhal commented Sep 9, 2019

+1

5 similar comments
@sidneibiz
Copy link

+1

@marcoshevaristo
Copy link

+1

@falexandre
Copy link

+1

@hemanuelx
Copy link

+1

@philipstefan
Copy link

+1

@yigitfindikli yigitfindikli self-assigned this Oct 3, 2019
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 3, 2019
@yigitfindikli yigitfindikli added this to the 8.1.0 milestone Oct 3, 2019
yigitfindikli added a commit that referenced this issue Oct 3, 2019
@yigitfindikli
Copy link
Contributor

Fixed in f539e1b

@lazovic6
Copy link

lazovic6 commented Oct 4, 2019

I think I have a solution for autocomplete, since it still doesn't work. As of 2018, you have to change autocomplete="new-password" instead of autocomplete="off" for it to work (autocomplete="off" doesn't work any more). Checked it, changed it in my project and it works. Hope you will fix this soon

@StruninIhor
Copy link

Still not fixed, prime-ng 11.4.2

@jacekzwroclawia
Copy link

jacekzwroclawia commented Jan 3, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests