Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button for Sidebar does not show the pointer when hovering #8159

Closed
davisb10 opened this issue Sep 23, 2019 · 0 comments
Closed

Close button for Sidebar does not show the pointer when hovering #8159

davisb10 opened this issue Sep 23, 2019 · 0 comments
Assignees
@yigitfindikli
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
8.0.4

Comments

@davisb10
Copy link
Contributor

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Visible from the showcase

https://www.primefaces.org/primeng/#/sidebar

Current behavior

  • Open any of the sidebar elements
  • Hover over the 'X' close button
  • The color changes with the theme, however the cursor does not switch to be a pointer

Expected behavior
Close Button should have a cursor: pointer when it is hovered over
@yigitfindikli yigitfindikli self-assigned this Sep 24, 2019
@yigitfindikli yigitfindikli added this to the 8.1.0 milestone Sep 24, 2019
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 24, 2019
yigitfindikli added a commit that referenced this issue Sep 25, 2019
@yigitfindikli
Merge pull request #8161 from davisb10/patch-5
6a18155 
Fixes #8159: Adds cursor: pointer to the :hover for .ui-sidebar-close
JacobSiegle pushed a commit to JacobSiegle/primeng that referenced this issue Oct 2, 2019
@davisb10 @JacobSiegle
Fixes primefaces#8159: Adds cursor: pointer to the :hover for .ui-sid…
aa62674 
…ebar-close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
8.0.4
Development

No branches or pull requests
2 participants
@davisb10 @yigitfindikli