-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Column-Filter): #13596 Auto close on Click Outside does not work #13619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Side Note: Some files i did not touch had a corrupted formatting and i had to re run prettier |
SoyDiego
approved these changes
Sep 6, 2023
ashikjs
approved these changes
Sep 7, 2023
ashikjs
suggested changes
Sep 7, 2023
ashikjs
approved these changes
Sep 7, 2023
Solved Merge Conflict |
cetincakiroglu
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13596
Notes for the other misc. Changes:
For some reason the other 3 files failed during the prettier check
![image](https://private-user-images.githubusercontent.com/1826849/266209633-70f6273c-85dd-4c95-be9e-a2de9b6b8400.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODYwMjksIm5iZiI6MTczOTM4NTcyOSwicGF0aCI6Ii8xODI2ODQ5LzI2NjIwOTYzMy03MGY2MjczYy04NWRkLTRjOTUtYmU5ZS1hMmRlOWI2Yjg0MDAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTg0MjA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTc3YjZjOWE2NjZhMWU1MmZmYzQxNTM1YjlmM2JiYmM2OTViNjRlY2I5OTA0ZGUxNTQ5ZTFiZjkxY2Y5MGUwYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.wmkXDqwYd6KTh-4sxQy5Ga1OwK6qV9MwtA4v0kjq_Y0)
So i just re ran the prettier command to format them.
As i reviewed those files i saw, that the document injection in the tiered menu was unused and cleaned up the code