fixed 15862 - fixed loading button when using the pButton directive #15893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
approved these changes
Jun 24, 2024
|
Good Job! @rosenthalj |
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #15862.
PR #15773 only partially fixed Issue #15736. It fixed the loading icon when the p-button component (<p-button>)was used. It did not fix the problem when a button with a pButton directive (<button pButton>) was used.
The first video shows the broken functionality before the fix. Note: all the p-button cases work properly.
The second video shows all the "loading" functionality working after the fix.
buttonLoadingProblem.mov
buttonLoadingFix.mov