Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15876 - TreeTable: Resizing one column resizes other columns a… #15927

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

B34v0n
Copy link

@B34v0n B34v0n commented Jul 1, 2024

…s well

the resizing is already done within the method "setWidth" so it doesn't need to be done before that.
Doing it twice resulted in adding the delta twice.

fixes #15876

Defect Fixes

When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

… columns as well

the resizing is already done within the method "setWidth" so it doesn't need
to be done before that.
Doing it twice resulted in adding the delta twice.
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 2:31pm

@cetincakiroglu
Copy link
Contributor

Hi,

Could you please link the related issue with the PR?

@cetincakiroglu cetincakiroglu added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. Resolution: Needs Issue An issue needs to be created for the pull request labels Jul 4, 2024
@B34v0n
Copy link
Author

B34v0n commented Jul 4, 2024

HI @cetincakiroglu, I put the link to the issue in the initial comment

@B34v0n
Copy link
Author

B34v0n commented Jul 25, 2024

Hi @cetincakiroglu, could you have a look at this again? I added the link to the issue (so no "needs Issue") and I can't make changes to the code, if it doesn't get reviewed.
Thanks

@cetincakiroglu cetincakiroglu removed the Resolution: Needs Issue An issue needs to be created for the pull request label Jul 25, 2024
@cetincakiroglu
Copy link
Contributor

Hi @B34v0n

Thanks a lot for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeTable: Resizing one column resizes other columns as well
2 participants