Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): dropdown height with virtual scroll #15971

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

leonidasdel
Copy link
Contributor

Fixes #15647

Copy link

vercel bot commented Jul 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jul 6, 2024 10:34pm

@rosenthalj
Copy link
Contributor

rosenthalj commented Jul 8, 2024

If Issue #15647 only occurs for virtual scroll, why not call calculateAutoSize() only when virtualscroll=true? Wouldn't a check be more efficient.

@leonidasdel
Copy link
Contributor Author

could be the case but maybe the condition inside the function is enough if (this._autoSize && !this.d_loading)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoComplete: Increased drop-down height on first search when using virtual scroll
3 participants