Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #15973 - TabMenu doesn't scroll to active item when it's set pr… #15982

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fixed #15973 - TabMenu doesn't scroll to active item when it's set pr… #15982

merged 3 commits into from
Jul 25, 2024

Conversation

mehmetcetin01140
Copy link
Contributor

Fixes #15973

@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 0:19am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@cetincakiroglu cetincakiroglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Jul 11, 2024
@cetincakiroglu
Copy link
Contributor

@mehmetcetin01140

It reverts the fix of #11411, it should not revert the fix while solving the issue

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@cetincakiroglu cetincakiroglu merged commit 0d7c90c into master Jul 25, 2024
2 of 3 checks passed
This was referenced Aug 16, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this pull request Aug 30, 2024
Open
@cetincakiroglu cetincakiroglu deleted the issue-15973 branch September 4, 2024 16:42
This was referenced Sep 6, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabMenu doesn't scroll to active item when it's set programatically
2 participants
@mehmetcetin01140 @cetincakiroglu