Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Calendar initial render performance #1817

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Improve Calendar initial render performance #1817

merged 2 commits into from
Jan 18, 2017

Conversation

variable-content
Copy link

Drastically improves initial render times for Calendar component when there are a large number of calendars on the page (>100).

In a test rendering 100 calendars render speed dropped from >4seconds to render, to less than 400ms.

Fix involves only rendering the calendar component when the overlay is display (either when the input field has focus, or is set to inline mode).

Fixes remaining issues for #1785

@variable-content variable-content changed the title Improve initial render time performance Improve Calendar initial render time performance Jan 16, 2017
@variable-content variable-content changed the title Improve Calendar initial render time performance Improve Calendar initial render performance Jan 16, 2017
@cagataycivici cagataycivici self-assigned this Jan 17, 2017
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 17, 2017
@cagataycivici cagataycivici merged commit aa30537 into primefaces:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants