Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add DataTable Checkbox Header Toggle All Pages Option #2424

Merged

Conversation

saverett
Copy link
Contributor

@saverett saverett commented Mar 30, 2017

Add headerCheckboxToggleAllPages DataTable property to allow the header checkbox on paged DataTables with checkbox multiple selection enabled to toggle the selection of items across all pages. Previously this was only possible via the onHeaderCheckboxToggle event--however, doing so produced strange results where the header checkbox would remain checked even if only the current page's items were selected. This change provides the expected results. This is an improvement over the original fix provided in #1412.
Update demo/documentation to reflect new property.

I created a new property for this so as to not alter the previous behavior of the header checkbox on paged DataTables--however, if that isn't a concern we could simplify this and remove the new property by just having the header checkbox toggle the selection of all items across all pages as its default behavior (for paged checkbox DataTables).

Add `headerCheckboxToggleAllPages` DataTable property to allow the header checkbox on paged DataTables with checkbox multiple selection enabled to toggle the selection of items across all pages.
Update demo/documentation to reflect new property.
@SUDHAGARAN
Copy link

Hi...When we will expect this feature?..Thank you

@saverett
Copy link
Contributor Author

saverett commented Apr 5, 2017

Thanks for your interest, @SUDHAGARAN. We'll need to wait to hear from @cagataycivici and the primeng team for an ETA.

@Duraimurugan
Copy link

can we have an ETA for this? I am desperately looking out for this feature
@cagataycivici can you please help on this?

@veplechuc
Copy link

any news on this feature? It Is already out?

@saverett
Copy link
Contributor Author

@veplechuc, we're still waiting to hear from the primeng team. Hopefully they will merge it soon.

@veplechuc
Copy link

@saverett thanks! It will be nice to have it soon!!.

@cagataycivici cagataycivici self-assigned this May 12, 2017
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label May 12, 2017
@cagataycivici cagataycivici added this to the 4.0.1 milestone May 12, 2017
@cagataycivici cagataycivici merged commit 425baad into primefaces:master May 15, 2017
@lommez
Copy link

lommez commented Aug 29, 2017

This feature works with lazy load?

@saverett
Copy link
Contributor Author

@lommez The table selection feature works by adding the elements for the selected rows into a selection array. Since not all elements are loaded at once with a lazy load table, this feature will not work with that configuration.

@lommez
Copy link

lommez commented Sep 13, 2017

Thanks @saverett.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants