Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add state css classes on checkbox and radio labels #3650

Merged
merged 2 commits into from
Aug 22, 2017

Conversation

GregKass
Copy link
Contributor

#3578: I've added unique dynamic classes to the checkbox and radio button features, so that the labels for these components can be styled based on checked, focused, and inactive states. I've searched through all of the components and have only found these two to be using <label> tags.

###Defect Fixes When submitting a PR, please also create an issue documenting the error.

###Feature Requests Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes. Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

@cagataycivici cagataycivici merged commit 6a5c1b3 into primefaces:master Aug 22, 2017
@cagataycivici
Copy link
Member

Thanks, for simplicity used ui-label-{state}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants