Enable MenuItem.id support for all Menus #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry there was a conflict because of another PR, is it possible to update your PR, then we'll merge. |
|
I have updated this PR as requested. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes/Feature Requests
This pull request addresses issue:
#2559
I have implemented the ability to add ID's to menu items and have the DOM reflect that. This is extremely crucial for doing things like end-to-end testing. It's a simple change that is applied to many files, and I hope in this respect it is small enough to be reviewed and accepted. For what it is worth, I have run the unit tests and they have all passed. Please let me know if there any issues and I would be happy to work with your team and address them.
Sincerely,
BustyLoli-Chan