Multiselect fix: disable options if selectionLimit reached by default value #7976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Why use
ngDoCheck
?I could set the value of
maxSelectionLimitReached
inwriteValue
method. But usingChangeDetection
ensures the check-boxes are updated even if
selectionLimit
oroptions
are updated later. I could notuse
ngAfterViewChecked
for that as the value ofmaxSelectionLimitReached
is used in the template.Why remove some code?
As the value of
maxSelectionLimitReached
is set thoughChangeDetection
, we don't need to set iton checkbox click event anymore.