Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismissable mask behaves over dialog #1167

Closed
NellyHaglund opened this issue Jan 24, 2020 · 0 comments · Fixed by #1168
Closed

Dismissable mask behaves over dialog #1167

NellyHaglund opened this issue Jan 24, 2020 · 0 comments · Fixed by #1168
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
4.0.0

Comments

@NellyHaglund
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
Having dismissableMask: true on DataTable closing dialog also when clicking inside of modal.

Expected behavior
This worked as expected in previous verions, where dismissable mask closes dialog when clicking outside the dialog.

  • PrimeReact version:
    3.4.0
NellyHaglund added a commit to NellyHaglund/primereact that referenced this issue Jan 24, 2020
@NellyHaglund
Stop propagation when clicking inside of dialog
d97954d 
Fixes: primefaces#1167
@NellyHaglund NellyHaglund mentioned this issue Jan 24, 2020
Merged
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jan 24, 2020
@mertsincan mertsincan added this to the 3.5.0 milestone Jan 24, 2020
mertsincan added a commit that referenced this issue Jan 24, 2020
@mertsincan
Merge pull request #1168 from NellyHaglund/bugfix/datatable-dismissab…
1508c48 
…le-mask

Fixed #1167 - Stop propagation when clicking inside of dialog
mertsincan added a commit that referenced this issue Jan 24, 2020
@mertsincan
Refactor #1167
5f810d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Stop propagation when clicking inside of dialog NellyHaglund/primereact
2 participants
@NellyHaglund @mertsincan