Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete dropdown no longer working #254

Closed
joshdanhall opened this issue Dec 14, 2017 · 2 comments
Closed

Autocomplete dropdown no longer working #254

joshdanhall opened this issue Dec 14, 2017 · 2 comments
Assignees
@Merve7
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
1.4.0

Comments

@joshdanhall
Copy link

Hi, as commented in this commit, Autocomplete dropdown no longer working. Was working in 1.3.0-rc.1 but broken in 1.3.0.
@cagataycivici
Copy link
Member

Can you post your code please?

@joshdanhall
Copy link
Author

Reproducable just using the sample code.

<AutoComplete dropdown={true} value={this.state.brand} onChange={(e) => this.setState({brand: e.value})} suggestions={this.state.brandSuggestions} completeMethod={this.suggestBrands.bind(this)} />

When running against 1.3.0-rc.1 suggestBrands is called when the dropdown is clicked, but against 1.3.0 it is not.

@Merve7 Merve7 closed this as completed in 63da4a2 Dec 20, 2017
@Merve7 Merve7 self-assigned this Dec 20, 2017
@Merve7 Merve7 added the Type: Bug Issue contains a defect related to a specific component. label Dec 20, 2017
@Merve7 Merve7 added this to the 1.3.1 milestone Dec 20, 2017
cagataycivici pushed a commit that referenced this issue Dec 22, 2017
Improved #254
4b75494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merve7 Merve7

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
3 participants
@cagataycivici @joshdanhall @Merve7