Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar dismissible works only if Sidebar is modal #2562

Closed
xAl3xFx opened this issue Jan 5, 2022 · 6 comments · Fixed by #2563
Closed

Sidebar dismissible works only if Sidebar is modal #2562

xAl3xFx opened this issue Jan 5, 2022 · 6 comments · Fixed by #2563
Assignees
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team
Milestone

Comments

@xAl3xFx
Copy link

xAl3xFx commented Jan 5, 2022

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
When using dismissible prop on the sidebar it only works when the Sidebar has the modal property.

Expected behavior
Using dismissible should work without having modal Sidebar as well.

  • PrimeReact version:
    7.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chrome

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all

@melloware
Copy link
Member

PR Submitted.

@melloware
Copy link
Member

Also I am going to submit another one because dismissable is spelled wrong everywhere its dismissible.

@yigitfindikli yigitfindikli added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Mar 22, 2022
@melloware melloware self-assigned this Aug 7, 2022
@melloware melloware added this to the 9.0.0 milestone Aug 7, 2022
@mertsincan mertsincan modified the milestones: 9.0.0, 8.4.0 Aug 22, 2022
@inad9300
Copy link
Contributor

I have encountered what seems to be the issue described here. In the following link, you can see how toggling dismissibility doesn't actually immediately toggle it. It is only after closing and reopening the sidebar that the dismissible flag is taken into account (so it's probably related to issue #1065 too).

https://codesandbox.io/s/primereact-test-forked-ll7b2p?file=/src/index.js

@inad9300
Copy link
Contributor

@melloware mentioning you in case my message wasn't seen, since this is a closed issue 🙃

@melloware
Copy link
Member

@inad9300 can you open a new ticket so we can track it. You can reference this issue and include your reproducer.

@melloware
Copy link
Member

@inad9300 I have a fix if you want to open a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants