Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoComplete: option to not focus input on dropdown click #2679

Closed
VsevolodGolovanov opened this issue Mar 15, 2022 · 1 comment · Fixed by #2680
Closed

AutoComplete: option to not focus input on dropdown click #2679

VsevolodGolovanov opened this issue Mar 15, 2022 · 1 comment · Fixed by #2680
Assignees
@melloware
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.0.0-rc.1

Comments

@VsevolodGolovanov
Copy link

VsevolodGolovanov commented Mar 15, 2022 •
edited by melloware
Loading

Current behavior
If you click the dropdown button AutoComplete focuses its input field. On mobile this makes on screen keyboard show up, which could be undesireable.

Expected behavior
AutoComplete should provide a property to disable this behavior. Kinda like Dropdown and others have filterInputAutoFocus.

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:

  • PrimeReact version:
    7.2.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
melloware added a commit to melloware/primereact that referenced this issue Mar 15, 2022
@melloware
Fix primefaces#2679: AutoComplete dropdownAutoFocus property
b0df099
@melloware melloware mentioned this issue Mar 15, 2022
Merged
@melloware
Copy link
Member

PR submitted I called it dropdownAutoFocus since there is already an autoFocus property on the component for automatically focusing on page load.

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 31, 2022
mertsincan added a commit that referenced this issue Mar 31, 2022
@melloware @mertsincan
Fix #2679: AutoComplete dropdownAutoFocus property (#2680)
09fd9f0 
Co-authored-by: mertsincan <sincan.mert@gmail.com>
@mertsincan mertsincan added this to the 8.0.0 milestone Mar 31, 2022
@mertsincan mertsincan modified the milestones: 8.0.0, 8.0.0-rc.1 Apr 4, 2022
@melloware melloware mentioned this issue Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Fix #2679: AutoComplete dropdownAutoFocus property melloware/primereact
4 participants
@melloware @VsevolodGolovanov @mertsincan @yigitfindikli