Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable re-order rows: can't reorder to last row when page is scrolled (event.pageY > 0) #2703

Closed
gugudwt opened this issue Mar 29, 2022 · 0 comments · Fixed by #2712
Closed
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@gugudwt
Copy link
Contributor

gugudwt commented Mar 29, 2022

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
Please fork the codesandbox below and create a case demonstrating your bug report. Issues without a codesandbox have much less possibility to be reviewed.

https://www.primefaces.org/primereact/datatable/reorder/

Current behavior
When try to reorder rows and the page has no scroll, i can drag the row to the last position too.
Indeed, if I scroll the page (for example half page) and try to drag and drop any row to the last position (after the last row) it is not possibile.

Expected behavior

I'm expecting that i can drag and drop any row after the last row at every scroll status.

Minimal reproduction of the problem with instructions
You can reproduce the bug directly in the documentation page (https://www.primefaces.org/primereact/datatable/reorder/)

Please tell us about your environment:
Mac OSX Monterey, silicon.

  • React version:
    ^16.12.0

  • PrimeReact version:
    ^7.2.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Google Chrome for arm64.

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Javascript/Typescript

gugudwt added a commit to gugudwt/primereact that referenced this issue Mar 30, 2022
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 31, 2022
@yigitfindikli yigitfindikli added this to the 8.0.0 milestone Mar 31, 2022
mertsincan pushed a commit that referenced this issue Mar 31, 2022
@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 31, 2022
@mertsincan mertsincan modified the milestones: 8.0.0, 8.0.0-rc.1 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants