Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccordionTab: keyboard navigation not working when inside a Dialog #2864

Closed
inad9300 opened this issue May 10, 2022 · 0 comments · Fixed by #3395
Closed

AccordionTab: keyboard navigation not working when inside a Dialog #2864

inad9300 opened this issue May 10, 2022 · 0 comments · Fixed by #3395
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.0

Comments

@inad9300
Copy link
Contributor

inad9300 commented May 10, 2022 •
edited
Loading

Describe the bug

When iterating over a page's elements with the tab key, the anchor within AccordionTab normally gets the focus, but not so when inside a Dialog.

Reproducer

https://codesandbox.io/s/strange-shaw-dn3qe1?file=/src/demo/AccordionDemo.js

PrimeReact version

8.0.1

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Open link
  2. Press the tab key repeatedly
  3. Notice the focus never sets on the accordion header

Expected behavior

Accordions should be accessible to keyboard users even when within a dialog.
@inad9300 inad9300 added the Type: Bug Issue contains a defect related to a specific component. label May 10, 2022
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Type: Bug Issue contains a defect related to a specific component. labels May 10, 2022
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 24, 2022
@melloware melloware self-assigned this Sep 30, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 30, 2022
@melloware
Fix primefaces#2864: AccordionTab tabIndex
3c289c0
@melloware melloware mentioned this issue Sep 30, 2022
Merged
@melloware melloware removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 30, 2022
@melloware melloware added this to the 8.6.2 milestone Sep 30, 2022
melloware added a commit that referenced this issue Sep 30, 2022
@melloware
Fix #2864: AccordionTab tabIndex (#3395)
7a34f8d
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.0
Development

Successfully merging a pull request may close this issue.

Fix #2864: AccordionTab tabIndex melloware/primereact
3 participants
@inad9300 @melloware @mertsincan