Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Preview mode do not hide buttons #2957

Closed
melloware opened this issue Jun 2, 2022 · 2 comments · Fixed by #2958
Closed

Image: Preview mode do not hide buttons #2957

melloware opened this issue Jun 2, 2022 · 2 comments · Fixed by #2958
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@melloware
Copy link
Member

Describe the bug

Image covers the transformation UI (zoom in/out, rotate) and even the closed icon. This occurs when using displaying an image with preview: https://primefaces.org/primereact/image/

Forum Post: https://forum.primefaces.org/viewtopic.php?f=57&t=72744&p=200319#p200319

Reproducer

See steps...

PrimeReact version

8.1.1

React version

18.x

Language

ALL

Build / Runtime

Next.js

Browser(s)

ALL

Steps to reproduce the behavior

Expected behavior

  1. The Transformation UI buttons (zoom in/out, rotate) should always be displayed when zooming in, the image should not cover the UI controls, so that users are able to zoom out or close modal.

  2. Ability to close the modal by using the "Esc" key.

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Jun 2, 2022
@melloware melloware self-assigned this Jun 2, 2022
@melloware melloware added this to the 8.2.0 milestone Jun 2, 2022
@melloware melloware changed the title Component: Title Image: Preview mode do not hide buttons Jun 2, 2022
melloware added a commit to melloware/primereact that referenced this issue Jun 2, 2022
@melloware melloware added the Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team label Jun 2, 2022
@melloware
Copy link
Member Author

Workaround:

.p-image-action.p-link {
    z-index: 9999;
}

melloware added a commit to melloware/primereact that referenced this issue Jun 2, 2022
@mertsincan mertsincan removed the Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team label Jun 6, 2022
@mertsincan
Copy link
Member

Fixed in 9f440b8

mertsincan added a commit that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants