Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable: globalFilter option triggered with old value #2996

Closed
omansak opened this issue Jun 17, 2022 · 11 comments · Fixed by #3437
Closed

Datatable: globalFilter option triggered with old value #2996

omansak opened this issue Jun 17, 2022 · 11 comments · Fixed by #3437
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@omansak
Copy link

omansak commented Jun 17, 2022

Adsız

Reproducer

https://codesandbox.io/s/wonderful-glade-k33wq6

PrimeReact version

8.1.1

React version

18.x

Language

TypeScript

Build / Runtime

Preact

Browser(s)

No response

Steps to reproduce the behavior

  1. Create DataTalbe
  2. Set golbalFilter prop
  3. Create a html input elemen
  4. Create a string react state
  5. set html input value and set change event to set react state
  6. watch onFilter,onValueChange event from prime DataTable

Expected behavior

No response

@omansak omansak added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jun 17, 2022
@melloware melloware changed the title Datatable globalFilter option triggered with old value Datatable: globalFilter option triggered with old value Jun 17, 2022
@mertsincan
Copy link
Member

Hi @omansak,

I tried many things but unfortunately, I couldn't replicate this issue. Could you please attach a sample codesandbox link for us to replicate? Also, could you please try the latest primereact version?

Best Regards,

@melloware
Copy link
Member

Will close for now and re-open if they provide a reproducer

@omansak
Copy link
Author

omansak commented Aug 8, 2022

I cannot share any sample or check again , sorry. Probably it has fixed in newer version. If i get again i will re-open.

Thanks.

@mertsincan
Copy link
Member

@omansak No worries ;) Thanks a lot for your update!

Sorry for the delayed response!

@durich
Copy link

durich commented Aug 17, 2022

I have this problem also:
a. onfilter is triggered with an old value
image

b. new problem, onfilter is not triggered when I erase the value on the searchbox
image

Here is the codesandbox link to reproduce, just type in search and view the console:

https://codesandbox.io/s/wonderful-glade-k33wq6

@melloware melloware reopened this Aug 17, 2022
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 17, 2022
@durich
Copy link

durich commented Aug 17, 2022

Hi, Just wanted to add, this two problems started in v8 (8.0.0 to 8.3.0), it works as intended in versions of Primereact v7 (7.0.0 to 7.2.1)

@omansak
Copy link
Author

omansak commented Sep 5, 2022

any update ? we need really fix this bug ?

@melloware
Copy link
Member

If you need immediate response for this bug you probably either need PRO support or to offer a patch PR.

@TripleSpeeder
Copy link

Did anyone find a workaround yet while there is no official fix?

@melloware
Copy link
Member

This replicates the issue and I am fixing it: https://codesandbox.io/s/exciting-northcutt-7or5sf?file=/src/demo/DataTableFilterDemo.tsx

@omansak
Copy link
Author

omansak commented Oct 8, 2022

@melloware thank you dude, your great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants