Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menubar: hide menu if no items in model #3190

Closed
gucal opened this issue Aug 26, 2022 · 0 comments · Fixed by #3191
Closed

Menubar: hide menu if no items in model #3190

gucal opened this issue Aug 26, 2022 · 0 comments · Fixed by #3191
Assignees
@gucal
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.5.0

Comments

@gucal
Copy link
Contributor

gucal commented Aug 26, 2022

Describe the bug

If there is no item added for the menu, the hamburger menu icon continues to appear in mobile view.

Reproducer

No response

PrimeReact version

8.4.0

React version

18.x

Language

ALL

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

If there is no item, the hamburger menu should not appear.
@gucal gucal added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 26, 2022
gucal added a commit to gucal/primereact that referenced this issue Aug 26, 2022
@gucal
Fix primefaces#3190: Menubar mobile view
9d1f320
@melloware melloware changed the title Component: Menubar Menubar: hide menu if no items in model Aug 26, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 26, 2022
@melloware melloware added this to the 8.5.0 milestone Aug 26, 2022
@melloware melloware linked a pull request Aug 27, 2022 that will close this issue
Fix #3190: Menubar mobile view hamburger menu #3191
Merged
melloware added a commit that referenced this issue Aug 27, 2022
@gucal @melloware
Fix #3190: Menubar mobile view hamburger menu (#3191)
3e18881 
* Fix #3190: Menubar mobile view

* Null check for model

Co-authored-by: Melloware <mellowaredev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gucal gucal

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.5.0
Development

Successfully merging a pull request may close this issue.

Fix #3190: Menubar mobile view hamburger menu gucal/primereact
2 participants
@melloware @gucal