Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Restore dialog size after maximize it close dialog keeping modal background active #3331

Closed
josmangarsal opened this issue Sep 16, 2022 · 2 comments · Fixed by #3336
Closed

Dialog: Restore dialog size after maximize it close dialog keeping modal background active #3331

josmangarsal opened this issue Sep 16, 2022 · 2 comments · Fixed by #3336
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.6.0

Comments

@josmangarsal
Copy link
Contributor

Describe the bug

Dialog disappear and modal background is active on click on minimize dialog

Reproducer

https://www.primefaces.org/primereact/dialog/

PrimeReact version

8.5.0

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 105.0.5195.102 (Build oficial) (64 bits)

Steps to reproduce the behavior

  1. Go to https://www.primefaces.org/primereact/dialog/
  2. Click on "Show" button in Maximizable section
  3. Click on maximize icon in dialog toolbar
  4. Click again on minimize icon in dialog toolbar

Expected behavior

Maximized dialog must be restored to original size on minimize it
@josmangarsal josmangarsal added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 16, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 16, 2022
@melloware
Fix primefaces#3331: Overlay flickering fix
07797e0
melloware added a commit to melloware/primereact that referenced this issue Sep 16, 2022
@melloware
Fix primefaces#3331: Overlay flickering fix
1a56139
This was referenced Sep 16, 2022
Closed
Merged
@melloware melloware self-assigned this Sep 16, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 16, 2022
@melloware melloware added this to the 8.6.0 milestone Sep 16, 2022
@melloware
Copy link
Member

Caused by #3122 which will we need to find a different fix for

melloware added a commit that referenced this issue Sep 16, 2022
@melloware
Fix #3331: Overlay flickering fix (#3336)
715ebc2
@melloware
Copy link
Member

Workaround just add this CSS:

.p-dialog:not([class*='p-dialog-']) {
    display: flex;
}

@melloware melloware added the Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team label Sep 19, 2022
This was referenced Sep 19, 2022
Closed
Closed
@mertsincan mertsincan modified the milestone: 8.6.0 Sep 22, 2022
@mertsincan mertsincan removed the Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.6.0
Development

Successfully merging a pull request may close this issue.

Fix #3331: Overlay flickering fix melloware/primereact
3 participants
@melloware @josmangarsal @mertsincan