Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputStyle gets ignored within overlays bound to body #3428

Closed
cagataycivici opened this issue Oct 6, 2022 · 1 comment · Fixed by #3763
Closed

InputStyle gets ignored within overlays bound to body #3428

cagataycivici opened this issue Oct 6, 2022 · 1 comment · Fixed by #3763
Assignees
@melloware
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Milestone
9.0.0-beta.1

Comments

@cagataycivici
Copy link
Member

Overlay components should add p-input-filled to their containers otherwise filled inputs are ignored e.g. dropdown filter, sidebar ...
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Oct 6, 2022
@cagataycivici cagataycivici added this to the 8.6.2 milestone Oct 6, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 6, 2022
@melloware melloware added Core Team Issue or pull request has been *opened* by a member of Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 7, 2022
@mertsincan mertsincan modified the milestones: 8.7.0, 8.7.1, 8.7.2 Oct 25, 2022
@mertsincan mertsincan modified the milestones: 8.7.2, 8.7.3 Nov 10, 2022
@mertsincan mertsincan modified the milestones: 8.7.3, 8.7.4 Dec 5, 2022
@melloware melloware assigned melloware and unassigned habubey Dec 8, 2022
melloware added a commit to melloware/primereact that referenced this issue Dec 8, 2022
@melloware
Fix primefaces#3428: p-input-filled/ripple-disabled added to overlays
26428da
@melloware melloware mentioned this issue Dec 8, 2022
Merged
@melloware
Copy link
Member

I looked exactly what PrimeVue was doing and made the same changes

melloware added a commit that referenced this issue Dec 8, 2022
@melloware
Fix #3428: p-input-filled/ripple-disabled added to overlays (#3763)
c1b3b95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3428: p-input-filled/ripple-disabled added to overlays melloware/primereact
4 participants
@cagataycivici @melloware @mertsincan @habubey