Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Setting value in range mode #3545

Closed
mjanota opened this issue Nov 1, 2022 · 3 comments · Fixed by #3547
Closed

Calendar: Setting value in range mode #3545

mjanota opened this issue Nov 1, 2022 · 3 comments · Fixed by #3547
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.2

Comments

@mjanota
Copy link

mjanota commented Nov 1, 2022

Describe the bug

I am trying to set the value programmatically in useEffect.
This throws Uncaught TypeError: newDate.getMonth is not a function on line 2657 in calendar.esm.js because newDate in range mode is an array

Reproducer

https://codesandbox.io/s/upbeat-nightingale-mrly1j?file=/src/demo/CalendarDemo.js

PrimeReact version

7.8.1

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@mjanota mjanota added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 1, 2022
@mjanota
Copy link
Author

mjanota commented Nov 1, 2022

The bug is not in PrimeReact 8.5.0

melloware added a commit to melloware/primereact that referenced this issue Nov 1, 2022
@melloware
Fix primefaces#3545: Calendar set range programmatically
bdc3df1
melloware added a commit to melloware/primereact that referenced this issue Nov 1, 2022
@melloware
Fix primefaces#3545: Calendar set range programmatically
ea26386
@melloware melloware mentioned this issue Nov 1, 2022
Merged
@melloware melloware self-assigned this Nov 1, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 1, 2022
@melloware melloware added this to the 8.7.2 milestone Nov 1, 2022
@melloware
Copy link
Member

Thanks for the report. Use 8.7.0 for now it will be fixed in 8.7.2.

melloware added a commit to melloware/primereact that referenced this issue Nov 1, 2022
@melloware
Fix primefaces#3545: Calendar set range programmatically
dc5192a
melloware added a commit to melloware/primereact that referenced this issue Nov 1, 2022
@melloware
Fix primefaces#3545: Calendar set range programmatically
daf0617
melloware added a commit to melloware/primereact that referenced this issue Nov 1, 2022
@melloware
Fix primefaces#3545: Calendar set range programmatically
1eb1248
melloware added a commit that referenced this issue Nov 1, 2022
@melloware
Fix #3545: Calendar set range programmatically (#3547)
c1d458d
@melloware
Copy link
Member

Yep you can use anything lower than 8.7.1 until 8.7.2 is released.

@melloware melloware mentioned this issue Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.2
Development

Successfully merging a pull request may close this issue.

Fix #3545: Calendar set range programmatically melloware/primereact
2 participants
@melloware @mjanota